Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly disable OOBE mode #3169

Closed
wants to merge 1 commit into from
Closed

Properly disable OOBE mode #3169

wants to merge 1 commit into from

Conversation

dantmnf
Copy link
Contributor

@dantmnf dantmnf commented Sep 25, 2024

Originated from torvalds/linux@d6de45e and also tested on Zenbook S 14 (UX5406SA).

Without setting 0x0005002F to 1, the keyboard backlight will keep breathing and uncontrollable.

Not sure how it will behave on other models though.

@seerge
Copy link
Owner

seerge commented Sep 25, 2024

@dantmnf hello, thanks

Can you clarify a bit what this endpoint does ? cause based on other user's test it seem to be backlight brightness toggle (i might be wrong tho). What does OOBE stands for ?

@dantmnf
Copy link
Contributor Author

dantmnf commented Sep 25, 2024

I think this should be a "feature" to indicate the system is starting by turning keyboard backlight on and off.

The term OOBE (out-of-box experience) is taken from Linux asus-wmi source, seems to be also reverse-engineered.

The two affected models AFAIK are on shining new platform (AMD Strix Point / Intel Lunar Lake), I'm not sure if Asus repurposed the endpoint in this generation.

@seerge
Copy link
Owner

seerge commented Sep 25, 2024

@dantmnf ok, then it could be that I have misunderstood sense of this in a first place.

So to summarize

Setting 0x0005002F to 1 - enables normal backlight operation and setting it to 0 - makes keyboard blink ?

@dantmnf
Copy link
Contributor Author

dantmnf commented Sep 26, 2024

setting it to 0 - makes keyboard blink ?

I haven't checked if this will make keyboard blink again - obviously not a feature wanted for daily use, but it do have value 0 after system startup.

@seerge
Copy link
Owner

seerge commented Sep 26, 2024

@dantmnf but can you set it to 0 and check what effect it has ? Does keyboard start blinking ?

@dantmnf
Copy link
Contributor Author

dantmnf commented Sep 26, 2024

Ok I will check it when the device comes back to me - maybe a few days later

@dantmnf
Copy link
Contributor Author

dantmnf commented Sep 29, 2024

@dantmnf but can you set it to 0 and check what effect it has ? Does keyboard start blinking ?

It has no effect. The keyboard won't start blinking again until a full shutdown and restart.

seerge added a commit that referenced this pull request Sep 30, 2024
@seerge
Copy link
Owner

seerge commented Sep 30, 2024

@dantmnf ok, great. Then I have misinterpreted sense of this endpoint based on on feedback of other users.

Since OOBE resets on reboot, i assume it will also reset on hibernate / wakeup from it. So it makes sense to run it every time device changes power mode.

I have added OOBE command to TUF Keyboard Power method instead (responsible for backlight zones in different states and running every time power is changed)

if (AppConfig.IsVivoZenPro() && DeviceGet(KBD_BACKLIGHT_OOBE) >= 0) DeviceSet(KBD_BACKLIGHT_OOBE, 1, "VIVO OOBE");

534dc3d

Can you check if this build works properly ?
GHelper.zip

@dantmnf
Copy link
Contributor Author

dantmnf commented Sep 30, 2024

i assume it will also reset on hibernate / wakeup from it.

You're right. I didn't think about the hibernate case.

Can you check if this build works properly ?

It works well.

@seerge
Copy link
Owner

seerge commented Sep 30, 2024

@dantmnf ok! then i assume it's fine as is now? Thanks for spotting and clarifying!

@dantmnf dantmnf closed this Sep 30, 2024
@memnon8711
Copy link

I have a new Vivobook S16 and have this issue when turning my laptop on. Do I need to trigger something in GHelper to stop the rainbow puke or is this just supposed to work out of the box with GHelper?

Side note - thanks for adding my laptop to OLED list.

@seerge
Copy link
Owner

seerge commented Oct 23, 2024

@memnon8711 you don't need to do anything, as far as you use latest release - it will set this command as soon as app starts. You can verify it by checking if record mentioning VIVO OOBE exists in %appdata%\GHelper\log.txt after app start.

@memnon8711
Copy link

I do see the line "VIVO OOBE = 1 : OK" in the log file. I just notice the rainbow RGB comes one when I turn on the computer and I have to cycle through the brightness to turn it off. Small nit.

@seerge
Copy link
Owner

seerge commented Oct 23, 2024

@memnon8711 can you check if this build behaves differently ?
GHelper.zip

@memnon8711
Copy link

That worked. The rainbow RGB was displaying when it booted up, but once Windows and GHelper loaded, it turned off the lighting and went back to the state I had it in previously. Thanks for the quick response.

@seerge
Copy link
Owner

seerge commented Oct 23, 2024

@memnon8711 ok, great . I just swapped OOBE command and initial backlight setting that app sets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants